refactor(ast/estree): alter Program start span with converter#10195
Conversation
github-actions
bot
added
A-ast
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
overlookmotel
force-pushed
the
04-03-refactor_ast_estree_alter_program_start_span_with_converter
branch
from
9979c1a to
e4d8baf
Compare
CodSpeed Instrumentation Performance ReportMerging #10195 will degrade performances by 4.8%Comparing Summary
Benchmarks breakdown
|
|
Does not alter serialized output, so merging without review. cc @therewillbecode FYI. |
Merge activity
|
Nice one! |
#10134 fixed the start span of `Program` in TS AST to align with TS-ESLint. Change the method this is achieved by - use a custom converter instead of mutating the AST in `to_estree_ts_json` and `to_pretty_estree_ts_json`. This method is more convoluted, but I think it's preferable if serialization does not have side effect of mutating the AST.
graphite-app
bot
force-pushed
the
04-03-refactor_ast_estree_alter_program_start_span_with_converter
branch
from
e4d8baf to
b662df4
Compare
graphite-app
bot
deleted the
04-03-refactor_ast_estree_alter_program_start_span_with_converter
branch
2 participants
#10134 fixed the start span of
Programin TS AST to align with TS-ESLint.Change the method this is achieved by - use a custom converter instead of mutating the AST in
to_estree_ts_jsonandto_pretty_estree_ts_json. This method is more convoluted, but I think it's preferable if serialization does not have side effect of mutating the AST.